update packages

lisp/org-ref/org-ref-citation-links.el

@@ -1,6 +1,6 @@
 ;;; org-ref-citation-links.el --- citation links for org-ref -*- lexical-binding: t; -*-
 ;;
-;; Copyright (C) 2021  John Kitchin
+;; Copyright (C) 2024  John Kitchin
 
 ;; Author: John Kitchin <jkitchin@andrew.cmu.edu>
 ;; Keywords: convenience
@@ -47,11 +47,15 @@
 ;; natmove like preprocessing is provided with `org-ref-cite-natmove'.
 ;;
 ;;; Code:
-
+(require 'org-keys)
 (require 'hydra)
 (require 'xref)
 (eval-when-compile (require 'subr-x))
 
+(defvar bibtex-completion-cache)
+(declare-function bibtex-completion-format-citation-cite "bibtex-completion")
+(declare-function bibtex-completion-show-entry "bibtex-completion")
+
 (defgroup org-ref-faces nil
   "A group for faces in `org-ref'."
   :group 'org-ref-faces)
@@ -592,13 +596,13 @@ PATH has the citations in it."
   "Get a tooltip for the cite at POSITION."
   (let ((key (get-text-property position 'cite-key)))
     (when key
-      (let ((bibtex-completion-bibliography (org-ref-find-bibliography))
-	    (has-pdf (when (bibtex-completion-find-pdf key) bibtex-completion-pdf-symbol))
-	    (has-notes (when (cl-some #'identity
-				      (mapcar (lambda (fn)
-						(funcall fn key))
-					      bibtex-completion-find-note-functions))
-			 bibtex-completion-notes-symbol)))
+      (let* ((bibtex-completion-bibliography (org-ref-find-bibliography))
+	     (has-pdf (when (bibtex-completion-find-pdf key) bibtex-completion-pdf-symbol))
+	     (has-notes (when (cl-some #'identity
+				       (mapcar (lambda (fn)
+						 (funcall fn key))
+					       bibtex-completion-find-note-functions))
+			  bibtex-completion-notes-symbol)))
 	(format "%s%s %s" (or has-pdf "") (or has-notes "")
 		(bibtex-completion-apa-format-reference key))))))
 
@@ -1048,21 +1052,17 @@ If not on a key, but on a cite, prompt for key."
    
    (t
     (let ((el (org-element-context))
-	  (cp (point))
-	  (org-ref-activate-cite-links t) ;; temporary
-	  data
-	  keys
-	  )
-      (and
-       (eq (org-element-type el) 'link)
-       (assoc (org-element-property :type el) org-ref-cite-types))
-      (save-excursion
-	;; We activate just this one link
-	(org-ref-cite-activate
-	 (org-element-property :begin el)
-	 (org-element-property :end el)
-	 (org-element-property :path el)
-	 nil))
+	  (org-ref-activate-cite-links t)) ;; temporary
+      (when (and
+	     (eq (org-element-type el) 'link)
+	     (assoc (org-element-property :type el) org-ref-cite-types))
+	(save-excursion
+	  ;; We activate just this one link
+	  (org-ref-cite-activate
+	   (org-element-property :begin el)
+	   (org-element-property :end el)
+	   (org-element-property :path el)
+	   nil)))
       ;; Now we have to handle some cases.
       (cond
        ;; on a key, return a key
@@ -1423,3 +1423,7 @@ Here is an example use:
 (provide 'org-ref-citation-links)
 
 ;;; org-ref-citation-links.el ends here
+
+;; Local Variables:
+;; byte-compile-warnings: (not docstrings docstrings-wide)
+;; End: